Repository navigation
fix(http): verify upstream certs for client-auth destinations (GHSA-p5c5-p2gx-h6q6) - #1255
Merged
tommysitu merged 1 commit intoNov 1, 2026
Conversation
…5c5-p2gx-h6q6) When a destination matched -client-authentication-destination and no -client-authentication-ca-cert was given, the upstream client was built with InsecureSkipVerify: true, so any server certificate was accepted. The -tls-verification flag was ignored on this path in both cases. Leave RootCAs nil when no CA cert is given so the system roots are used, and set InsecureSkipVerify from -tls-verification like the default client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-client-authentication-ca-cert, upstream connections setInsecureSkipVerify: trueand accepted any server certificate.-tls-verificationwas ignored on this path.InsecureSkipVerifyfollows-tls-verification, same as the default client.Test plan
go test ./core/... -count=1core/http_test.goagainst a TLS server that requires a client cert, covering verification on and off, with and without a CA certgo vet🤖 Generated with Claude Code